Martin Sivák has posted comments on this change. Change subject: PendingResourceManager for tracking resources in WaitForLaunch ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/40136/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java: Line 283 Line 284 Line 285 Line 286 Line 287 > ah I see I see, so need to remove "lastDecreasedVds" field.. Done https://gerrit.ovirt.org/#/c/40136/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 1183: public void setFenceAgents(List<FenceAgent> fenceAgents) { Line 1184: this.fenceAgents = fenceAgents; Line 1185: } Line 1186: Line 1187: public void calculateFreeVirtualMemory() { > I agree, I just was not sure where the right place is. We need the value bo I updated this so the attributes here are only used as a cache for REST and UI. The only code that writes them to DB is the VdsManager when notified about a change by the PendingResourceManager and scheduler. Line 1188: if (getMemCommited() != null && getPhysicalMemMb() != null && getReservedMem() != null) { Line 1189: maxSchedulingMemory = (getMaxVdsMemoryOverCommit() * getPhysicalMemMb() / 100.0f) Line 1190: - getMemCommited() Line 1191: - getReservedMem() -- To view, visit https://gerrit.ovirt.org/40136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie741b8e244acb64e470af83252d90ec134ba7f8e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomer Saban <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
