Martin Peřina has posted comments on this change. Change subject: core: backup awareness refactoring ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40389/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLogId.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLogId.java: Line 42: if (!(obj instanceof EngineBackupLogId)) { Line 43: return false; Line 44: } Line 45: EngineBackupLogId other = (EngineBackupLogId)obj; Line 46: return (scope.equals(other.getScope()) && doneAt.equals(other.getDoneAt())); > what is the advantage here ? To prevent NPE when scope and/or doneAt in current instance is null Line 47: } Line 48: Line 49: Line 50: } -- To view, visit https://gerrit.ovirt.org/40389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82c4a5372a9108d8c4d5960112f27a0b94f3b654 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
