Alexander Wels has posted comments on this change. Change subject: webadmin: GuideMe can't activate hosts ......................................................................
Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/39992/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GuideModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/GuideModel.java: Line 123: new AsyncQuery(this, Line 124: new INewAsyncCallback() { Line 125: @Override Line 126: public void onSuccess(Object target, Object returnValue) { Line 127: ArrayList<VDS> hosts = ((VdcQueryReturnValue) returnValue).getReturnValue(); This can be a List. Line 128: boolean succeeded = true; Line 129: for (VDS host : hosts) { Line 130: if (!host.getVdsGroupId().equals(hostClusterIdMap.get(host.getId()))) { Line 131: succeeded = false; Line 156: } Line 157: }; Line 158: Line 159: // Execute the timer to expire 5 seconds in the future Line 160: timer.schedule(5000); Just a question, maybe something for a follow up patch, but do we want to allow the admin to configure this? I can see it being nice to allow more or less time for this. Line 161: } Line 162: }, Line 163: this); Line 164: } Line 169: new AsyncQuery(this, Line 170: new INewAsyncCallback() { Line 171: @Override Line 172: public void onSuccess(Object target, Object returnValue) { Line 173: ArrayList<VDS> hosts = ((VdcQueryReturnValue) returnValue).getReturnValue(); This can be a List Line 174: boolean succeeded = true; Line 175: for (VDS host : hosts) { Line 176: if (host.getStatus() != VDSStatus.Up) { Line 177: succeeded = false; https://gerrit.ovirt.org/#/c/39992/4/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 2234: Line 2235: @DefaultStringValue("Activating the Hosts may take a while, please close the 'Guide Me' window and track the Hosts activation via the Events tab or the Hosts tab") Line 2236: String hostActivationTimeOut(); Line 2237: Line 2238: @DefaultStringValue("Changing Host clusters taking longer than expected, please close the 'Guide Me' window and activate hosts via the Hosts tab") Changing Host Clusters is taking longer than expected, please close the 'Guide Me' window and activate hosts via the Hosts tab. Line 2239: String hostChangeClusterTimeOut(); Line 2240: Line 2241: @DefaultStringValue("Host cannot be set highly available when 'Do not allow migration' or 'Allow manual migration' is selected") Line 2242: String hostNonMigratable(); -- To view, visit https://gerrit.ovirt.org/39992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983ad2c714ff945541de5f0b0d6f95e524f7edbc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
