Omer Frenkel has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40100/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 285: @Override Line 286: public MigrateStatusReturnForXmlRpc migrateStatus(String vmId) { Line 287: JsonRpcRequest request = new RequestBuilder("VM.getMigrationStatus").withParameter("vmID", vmId).build(); Line 288: Map<String, Object> response = new FutureMap(this.client, request).withResponseKey("response") Line 289: .withResponseType(Long.class); did you make sure this doesnt break older vdsms? (3.5 is the first version that use json i think) Line 290: return new MigrateStatusReturnForXmlRpc(response); Line 291: } Line 292: Line 293: @Override -- To view, visit https://gerrit.ovirt.org/40100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic18c6db9a85167b1c4b85bdad22cf63f0204f378 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
