Allon Mureinik has posted comments on this change. Change subject: core: Check attached VMs snapshot status when moving a disk ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40080/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java: Line 181: } Line 182: return false; Line 183: } Line 184: Line 185: private boolean validateVmSnapshotStatus() { > I agree with the comment about the UI, and aside for the fact that it's not Not worth the effort - if the VM is in any previewing state, we should block moving the disk. The UI also isn't worth the effort - a CDA message is good enough. Line 186: SnapshotsValidator snapshotsValidator = getSnapshotsValidator(); Line 187: for (Pair<VM, VmDevice> pair : getVmsWithVmDeviceInfoForDiskId()) { Line 188: VmDevice vmDevice = pair.getSecond(); Line 189: if (vmDevice.getSnapshotId() == null) { // Skip check for VMs with connected snapshot -- To view, visit https://gerrit.ovirt.org/40080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
