Shubhendu Tripathi has posted comments on this change. Change subject: engine: Query to get list of cluster with nodes ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40396/2/packaging/dbscripts/vds_groups_sp.sql File packaging/dbscripts/vds_groups_sp.sql: Line 263: AS $procedure$ Line 264: BEGIN Line 265: RETURN QUERY SELECT vds_groups_view.* Line 266: FROM vds_groups_view Line 267: WHERE EXISTS (SELECT * from vds_static WHERE vds_group_id = vds_groups_view.vds_group_id); > there is no need for "select *" where checking for existence, please change Done Line 268: END; $procedure$ Line 269: LANGUAGE plpgsql; Line 270: Line 271: --This SP updates the vds_group emulated machine and the detection mode -- To view, visit https://gerrit.ovirt.org/40396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c06388ec88436518ce2e8bd3855d64ba66400b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
