Yair Zaslavsky has posted comments on this change.
Change subject: core: Performance improvements - replacing search by query
......................................................................
Patch Set 1: (1 inline comment)
Minor comment.
Besides that - looks good.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
Line 57: public static final String UpVdssInCluster = "HOST: status = UP
and CLUSTER = {0}";
Line 58: public static final String DesktopsInStoragePoolQuery = "VMS:
DATACENTER = {0}";
Line 59:
Line 60: public static List<VDS> GetAllRunningVdssInPool(storage_pool pool)
{
Line 61: return
DbFacade.getInstance().getVdsDao().getAllForStoragePoolAndStatus(pool.getId(),
VDSStatus.Up);
Why not use here getVdsDAO() ? as in getAllRunningVdssInPool
Line 62: }
Line 63:
Line 64: protected List<VDS> getAllRunningVdssInPool() {
Line 65: return
getVdsDAO().getAllForStoragePoolAndStatus(getStoragePool().getId(),
VDSStatus.Up);
--
To view, visit http://gerrit.ovirt.org/8457
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c1adda55bd27beef2907bf0ed8a0f8bc274e495
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
