anmolbabu has posted comments on this change. Change subject: webadmin : geo-rep status detail pop up ......................................................................
Patch Set 6: (7 comments) https://gerrit.ovirt.org/#/c/32100/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 281: if(getWindow() != null) { Line 282: closeWindow(); Line 283: } Line 284: final VolumeGeoRepSessionDetailsModel windowModel = new VolumeGeoRepSessionDetailsModel(); Line 285: > Set HashName and HelpTag for the pop up. Its required to link the help link Done Line 286: final UIConstants constants = ConstantsManager.getInstance().getConstants(); Line 287: windowModel.setTitle(constants.geoReplicationSessionDetailsTitle()); Line 288: Line 289: UICommand okCommand = new UICommand("closeWindow", this);//$NON-NLS-1$ Line 295: for(final GlusterGeoRepSessionDetails detail : details) { : AsyncDataProvider.getInstance().getGlusterVolumeBrickById(new AsyncQuery(new INewAsyncCallback() { : @Override : public void onSuccess(Object model, Object returnValue) { : GlusterBrickEntity brick = (GlusterBrickEntity) returnValue; : if(brick == null) { : brick = new GlusterBrickEntity(); : brick.setServerName(constants.notAvailableLabel()); : } : detailRows.add(new EntityModel<VolumeGeoRepSessionDetailsModel.GeoRepSessionDetailsSummaryTableRow>(new GeoRepSessionDetailsSummaryTableRow(brick.getServerName(), detail))); : if(detailRows.size() == details.size()) { : windowModel.getGeoRepSessionSummary().setItems(detailRows, detailRows.get(0)); : setWindow(windowModel); : } : } : }), detail.getMasterBrickId()); : } > Is there any other better way to get the server name for each brick in the AFAIK, there are 2 alternatives : 1. runMultipleQuery 2. get it in our entity itself. I see 1 is the easiest as it required most minimal changes and hence doing it in my patch to follow. Line 314: Guid volumeId, Guid clusterId) > I don't see a usage for volumeID and clusterID. Why do need this? Done https://gerrit.ovirt.org/#/c/32100/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepSessionDetailsModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepSessionDetailsModel.java: Line 15: GeoRepSessionDetailsSummaryTableRow > GeoRepSessionDetailsSummary can be enough Done https://gerrit.ovirt.org/#/c/32100/6/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 310: Geo Rep > Geo-Replication Done https://gerrit.ovirt.org/#/c/32100/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 3813: geoRepMasterNode(); > Where it is used and where geoRepSessionHostName() is used. You are right this is not used but geoRepSessionHostName() is used in VolumeGeoRepSessionDetailsPopUpView https://gerrit.ovirt.org/#/c/32100/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.ui.xml: Line 42: > remove TWS Done -- To view, visit https://gerrit.ovirt.org/32100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cc6151fb71a4aa67dc76ec8dd8c93b76796f165 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
