Michael Pasternak has posted comments on this change.
Change subject: restapi: Don't raise 404 if slave not found
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java
Line 366: ifaces.add(iface);
Line 367: if (nic.isSetBonding() && nic.getBonding().isSetSlaves())
{
Line 368: for (HostNIC slave :
nic.getBonding().getSlaves().getSlaves()) {
Line 369: VdsNetworkInterface slaveIface = map(slave,
slave.getId() == null
Line 370: ? lookupInterfaceByName(slave.getName())
: lookupInterfaceById(slave.getId()));
i'm not sure this change is accurate, if by-name failed and by-id failed should
be returned notFound() ...,
as if you cannot find interface you cannot use it as slave ....
can you explain what is the use-case for this change?
Line 371: slaveIface.setBondName(nic.getName());
Line 372: ifaces.add(slaveIface);
Line 373: }
Line 374: }
--
To view, visit http://gerrit.ovirt.org/8490
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20c86e56b102e4c6318608f8d4ba50757fcce12f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
