Ori Liel has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 2115: urlparams: {}
Line 2116: headers:
Line 2117: Content-Type: {value: application/xml|json, required: true}
Line 2118: Correlation-Id: {value: 'any string', required: false}
Line 2119: Filter: {value: true|false, required: false}
you're right, I missed it
Line 2120: - name: /api/templates/{template:id}/nics|rel=get
Line 2121: request:
Line 2122: body:
Line 2123: parameterType: null
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java
Line 162:
Line 163: protected Guid lookupStorageDomainIdByName(String name) {
Line 164: return getEntity(storage_domains.class,
SearchType.StorageDomain, "Storage: name=" + name).getId();
Line 165: }
Line 166: }
Ok, I suggest we open a code-enhancement issue for this, because this type of
problem - no utility objects, everything in resources either duplicated or
stored in inappropriate base classes - repeats itself quite a lot throughout
the API
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java
Line 16:
Line 17: protected BackendTemplateDisksResource collection;
Line 18:
Line 19: public BackendTemplateDiskResource(Class<Disk> modelType,
Line 20:
Class<org.ovirt.engine.core.common.businessentities.Disk> entityType,
See BackendVmDiskResource constructor
Line 21: Guid guid,
Line 22: BackendTemplateDisksResource
collection,
Line 23: String... subCollections) {
Line 24: super(modelType, entityType, guid, collection, subCollections);
--
To view, visit http://gerrit.ovirt.org/8428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic629b331e4753b24ef02612ff50cb6a4457cfd58
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
