Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: Number field reporting wrong error ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/37244/7/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java: Line 226: void onIsValidPropertyChange(HasValidation editor, EntityModel model) { Line 227: if (model.getIsValid()) { Line 228: editor.markAsValid(); Line 229: } else { Line 230: //The entity validator will mark the entity valid before running the validation > We could but I am uncertain if that would break any other behavior I am not I agree, the change here is safer compared to what I suggested. It was just an idea. Line 231: //this will cause the editor to be marked valid if it was invalid due to an entity validation Line 232: //error. Then if the validation is invalid again this will update the error message. So there is Line 233: //no possibility to go from one invalid reason to another without the editor message being updated. Line 234: if (editor.isValid()) { -- To view, visit https://gerrit.ovirt.org/37244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3702cb370528a0baf6a176fa89cd736596a10ff2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
