Piotr Kliczewski has posted comments on this change. Change subject: vdsbroker: async vdscommand ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/40565/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java: Line 54: // and we want returnValue clean from last run. Line 55: _returnValue = new VDSReturnValue(); Line 56: getVDSReturnValue().setSucceeded(true); Line 57: if (isAsync()) { Line 58: setAsyncResult(); > I wonder whether to call it setAsyncResult, or something different. As it a Done Line 59: return; Line 60: } Line 61: executeVDSCommand(); Line 62: } catch (RuntimeException ex) { https://gerrit.ovirt.org/#/c/40565/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java: Line 72: String > about the try-catch-finally block, don't we need it here as well? Done -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c8a05c286a9008ef9a08ac7da02bc7211c4af9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
