Vitor de Lima has posted comments on this change.

Change subject: WIP: core: bulk queries for VMConsoleProxyServlet
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/40620/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmConsole.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmConsole.java:

Line 6: import javax.validation.constraints.Size;
Unused import.


Line 39: return ObjectUtils.objectsEqual(vm_guid, other.vm_guid) &&
       :                ObjectUtils.objectsEqual(vm_name, other.vm_name) &&
       :                ObjectUtils.objectsEqual(address, other.address);
"other" must be cast into a VmConsole object.


-- 
To view, visit https://gerrit.ovirt.org/40620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id60c40f7f7d19d1622ca5fdbe34f2a90942be51d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to