Alon Bar-Lev has posted comments on this change. Change subject: tools: extensions-tool: initial implementation logger ......................................................................
Patch Set 39: (1 comment) https://gerrit.ovirt.org/#/c/37886/39/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java: Line 68: try (InputStream stream = getClass().getResourceAsStream("arguments.properties")) { Line 69: parser = new ArgumentsParser(stream, "module"); Line 70: } Line 71: parser.parse(args); Line 72: moduleArgs = parser.getArgMap(); where do you check for errors? Line 73: if((Boolean)moduleArgs.get("help")) { Line 74: printUsage(parser); Line 75: throw new ExitException("Help", 0); Line 76: } -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 39 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ondra Machacek <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
