Maor Lipchuk has uploaded a new change for review. Change subject: core: Use set instead of List to prevent duplicate key violiation ......................................................................
core: Use set instead of List to prevent duplicate key violiation Use set instead of List to prevent duplicate key violiation while building the associated command entities. Change-Id: I55a2933da86aec6202fd806bf1a5701811ed1207 Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/40709/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java index 83d107f..d212dc8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java @@ -3,10 +3,12 @@ import java.util.ArrayList; import java.util.Collection; import java.util.Collections; +import java.util.HashSet; import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.Map.Entry; +import java.util.Set; import java.util.concurrent.Callable; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ExecutionException; @@ -179,7 +181,7 @@ if (subjectEntities.length == 0) { return Collections.emptyList(); } - List<CommandAssociatedEntity> results = new ArrayList<>(subjectEntities.length); + Set<CommandAssociatedEntity> results = new HashSet<>(subjectEntities.length); for (SubjectEntity subjectEntity : subjectEntities) { results.add(new CommandAssociatedEntity(cmdId, subjectEntity.getEntityType(), subjectEntity.getEntityId())); -- To view, visit https://gerrit.ovirt.org/40709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I55a2933da86aec6202fd806bf1a5701811ed1207 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
