Moti Asayag has posted comments on this change. Change subject: core: add mergable flag to CustomDeviceProperties ......................................................................
Patch Set 1: (1 comment) please note there is a similar patch here: https://gerrit.ovirt.org/#/c/40682/ https://gerrit.ovirt.org/#/c/40708/1/packaging/etc/engine-config/engine-config.properties File packaging/etc/engine-config/engine-config.properties: Line 296: WebSocketProxyTicketValiditySeconds.description="Validity (in seconds) of tickets issued for websocket proxy." Line 297: WebSocketProxyTicketValiditySeconds.type=Integer Line 298: CustomDeviceProperties.description="Definition of custom properties per each device type" Line 299: CustomDeviceProperties.type=DeviceCustomProperties Line 300: CustomDeviceProperties.mergable=true I can't understand how this will work. 1. no delimiter is provided. 2. how the merge will be executed ? For example, the current value from db for this property is: CustomDeviceProperties: {type=interface;prop={SecurityGroups=^(?:(?:[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}, *)*[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}|)$}} version: 3.4 So in this map a specific logic should be applied for adding a field. Could you ellaborate how it was verified ? Line 301: UserDefinedNetworkCustomProperties.description="User defined network custom properties." Line 302: UserDefinedNetworkCustomProperties.type=CustomProperties Line 303: GlusterRefreshRateHooks.description="Refresh rate (in seconds) of gluster hooks from gluster servers" Line 304: GlusterRefreshRateHooks.type=Integer -- To view, visit https://gerrit.ovirt.org/40708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60b8abe212af4031e9a352778811d102ff3076a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
