Moti Asayag has posted comments on this change. Change subject: core: Introduce HostSetupNetworksParameters parameters ......................................................................
Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/32776/20/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java: Line 30: private List<NetworkAttachment> removedNetworkAttachments; Line 31: Line 32: private List<Bond> bonds; Line 33: Line 34: private List<Bond> removedBonds; > Same here, is list of ids enough? it can be name or id, which identifies the bond. if we'll have the logic on the rest side to convert host-name to id, so yes, we can settle for ids. Line 35: Line 36: private boolean rollbackOnFailure = true; Line 37: Line 38: @ConfiguredRange(min = 1, maxConfigValue = ConfigValues.NetworkConnectivityCheckTimeoutInSeconds, -- To view, visit https://gerrit.ovirt.org/32776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If353c08a8db257333d7696df0c7c887d179bc41a Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
