Amit Aviram has posted comments on this change. Change subject: core: Extracting virtIO-scsi disabling check in CDA ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40710/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java: Line 164: if (Boolean.FALSE.equals(getParameters().isVirtioScsiEnabled()) && Line 165: !validate(vmValidator.canDisableVirtioScsi(getAdjustedDiskImagesFromConfiguration()))) { Line 166: return false; Line 167: } Line 168: else return true; > please use project formatter, this should be inside {} Done Line 169: } Line 170: Line 171: protected SnapshotsValidator createSnapshotsValidator() { Line 172: return new SnapshotsValidator(); -- To view, visit https://gerrit.ovirt.org/40710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic581f078b071b029444c699f08c7de8e87518723 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
