Michael Pasternak has posted comments on this change.
Change subject: restapi: BZ861929 - Don't require template for clone-vm from
snapshot
......................................................................
Patch Set 1: (1 inline comment)
one inline comment.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
Line 109: Guid storageDomainId =
Line 110: (vm.isSetStorageDomain() &&
vm.getStorageDomain().isSetId()) ? asGuid(vm.getStorageDomain().getId())
Line 111: : Guid.Empty;
Line 112: if (isCreateFromSnapshot(vm)) {
Line 113: createVmFromSnapshot(vm);
this-use case is not available here
Line 114: } else if (vm.isSetDisks() && vm.getDisks().isSetClone()
&& vm.getDisks().isClone()) {
Line 115: response = cloneVmFromTemplate(staticVm, vm,
templateId);
Line 116: } else if (Guid.Empty.equals(templateId)) {
Line 117: response = addVmFromScratch(staticVm, vm,
storageDomainId);
--
To view, visit http://gerrit.ovirt.org/8433
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e49482c2777c5fd6d0aa97ba2c4e1b37c2bec2e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
