Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: using cloud-init to run engine-setup ......................................................................
Patch Set 16: (2 comments) https://gerrit.ovirt.org/#/c/40546/16/src/ovirt_hosted_engine_setup/constants.py File src/ovirt_hosted_engine_setup/constants.py: Line 691 Line 692 Line 693 Line 694 Line 695 > I'm always a bit uncertain about saving passwords in the answer-file. Sandr We do save them in engine-setup. Just have to make sure it's secured - I see that it's not, currently. Not urgent, we have another bug for full automation. https://gerrit.ovirt.org/#/c/40546/16/src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py File src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py: Line 264: user_data += ( Line 265: 'write_files:\n' Line 266: ' - content: |\n' Line 267: ' [environment:default]\n' Line 268: ' OVESETUP_CONFIG/adminPassword=str:{password}\n' > Temporary file got destroyed after ISO creation. IMO "destroying" is not enough - some of these processes take a long time. Line 269: ' OVESETUP_CONFIG/fqdn=str:{fqdn}\n' Line 270: ' path: {heanswers}\n' Line 271: ' owner: root:root\n' Line 272: ' permissions: \'0640\'\n' -- To view, visit https://gerrit.ovirt.org/40546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I305232fc44a524fd53e2d7fbd819ab5b95d4931c Gerrit-PatchSet: 16 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
