Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: using cloud-init to run engine-setup
......................................................................


Patch Set 21:

(1 comment)

https://gerrit.ovirt.org/#/c/40546/21/src/plugins/ovirt-hosted-engine-setup/engine/health.py
File src/plugins/ovirt-hosted-engine-setup/engine/health.py:

Line 189:                         raise RuntimeError(_('Engine is still not 
reachable'))
Line 190:                     self.logger.info(
Line 191:                         _('Engine is still not reachable, waiting...')
Line 192:                     )
Line 193:                 time.sleep(10)
Actually it was better inside the 'else', so that when engine is up you do not 
wait...
Line 194: 
Line 195: 


-- 
To view, visit https://gerrit.ovirt.org/40546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I305232fc44a524fd53e2d7fbd819ab5b95d4931c
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to