Alon Bar-Lev has posted comments on this change. Change subject: uutils: added new cli parser ......................................................................
Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/40157/12/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/Argument.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/Argument.java: Line 15: private String metavar; Line 16: private boolean multivalue; Line 17: private String value; Line 18: Line 19: enum Type { > Sorry, but HasArg IMO doesn't describe the enum any better than Type. for these who understand getopt it is while you trying to take it to somewhere else. Line 20: HAS_ARGUMENT, Line 21: OPTIONAL_ARGUMENT, Line 22: NO_ARGUMENT; Line 23: https://gerrit.ovirt.org/#/c/40157/12/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java: Line 152: Line 153: /** Line 154: * Map which stores parsed converted arguments. Line 155: */ Line 156: private Map<String, Argument> arguments = new HashMap<>(); > It's good behavior and you don't look up through the whole file what's the it was good behavior in java-1.0 or java-2.0 where it was impossible. constructor should initialize only members that their value are result of constructor parameters. Line 157: Line 158: /** Line 159: * Set of mandatory arguments to check if user specified all of them. Line 160: */ -- To view, visit https://gerrit.ovirt.org/40157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Mooli Tayer <[email protected]> Gerrit-Reviewer: Ondra Machacek <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
