Martin Sivák has posted comments on this change. Change subject: WIP:VDSM interface using JSON-RPC ......................................................................
Patch Set 7: (1 comment) I like this, the only issue I have is with the VDSM code reuse. Reuse is a good thing, but MOM should work even without VDSM (+ VDSM is not packaged as a proper library..) https://gerrit.ovirt.org/#/c/37294/7/mom/HypervisorInterfaces/vdsmrpcInterface.py File mom/HypervisorInterfaces/vdsmrpcInterface.py: Line 26: import stomp Line 27: import stomp.exception Line 28: Line 29: import sys Line 30: sys.path.append('/usr/share/vdsm') I can't say I like to see this in code.. it adds the path for everybody. Line 31: from virt.utils import ExpiringCache Line 32: Line 33: from mom.HypervisorInterfaces.HypervisorInterface import HypervisorInterface, \ Line 34: HypervisorInterfaceError -- To view, visit https://gerrit.ovirt.org/37294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7671dd151cc5342728eb864925242f1d04c47b05 Gerrit-PatchSet: 7 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
