Francesco Romani has posted comments on this change. Change subject: WIP: core: bulk queries for VMConsoleProxyServlet #1 ......................................................................
Patch Set 1: The only problem I see is that "loginName"/"userName" is just needed for logging/reporting purposes. The current VMConsoleProxy code uses a nested query to fetch the name, given the userId, from the DB. I don't think to duplicate the login name is any better than this. -- To view, visit https://gerrit.ovirt.org/40698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic58b0e92ee416fb43661910632970055d3c23e8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
