Martin Mucha has posted comments on this change. Change subject: restapi: Add support for Network Attachements. ......................................................................
Patch Set 27: (1 comment) https://gerrit.ovirt.org/#/c/32775/27/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java: Line 57: } Line 58: } Line 59: Line 60: if (!ipv4configuration.getIPs().isEmpty()) { Line 61: IP ip = ipv4configuration.getIPs().get(0); > Don't we use the rest of the IP addresses provided by the user? If so why d updated entity so that all addresses can be passed to bll and added validation, that only one entity passed to bll is considered to be valid input. Done. Line 62: Line 63: if (ip.isSetAddress()) { Line 64: entity.getIpConfiguration().setAddress(ip.getAddress()); Line 65: } -- To view, visit https://gerrit.ovirt.org/32775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ac91eea1000f7fdf6105777343a1ac1c77368d Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
