Moti Asayag has posted comments on this change. Change subject: webadmin: Enable 'Upgrade' action for all host types ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/40706/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 1534: model.setVds(host); Line 1535: setWindow(model); Line 1536: model.setTitle(ConstantsManager.getInstance().getConstants().installHostTitle()); Line 1537: model.setHelpTag(HelpTag.upgrade_host); Line 1538: model.setHashName("install_host"); //$NON-NLS-1$ > The hashName used to be the mapper between the dialog and its documentation 10x. fixed. Line 1539: model.getOVirtISO().setIsAvailable(false); Line 1540: Line 1541: model.getOverrideIpTables().setIsAvailable(false); Line 1542: model.getActivateHostAfterInstall().setEntity(true); Line 2125: Line 2126: } Line 2127: Line 2128: private boolean canUpgradeHost(VDS host) { Line 2129: return host.isUpdateAvailable() > The problem is there is inconsistency in the ui. You can have the altert bu Done Line 2130: && VdcActionUtils.canExecute(Arrays.asList(host), VDS.class, VdcActionType.UpgradeHost); Line 2131: } Line 2132: Line 2133: private boolean singleHostSelected(ArrayList<VDS> items) { -- To view, visit https://gerrit.ovirt.org/40706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic064f6e8bdefe47fc0a16df2660afcb53782bbec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
