Tomas Jelinek has posted comments on this change. Change subject: restapi: Allow creation of new disks as copy of any existing disk ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38367/3/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 1214: action.storage_domain.id|name: xs:string Line 1215: optionalArguments: Line 1216: action.async: xs:boolean Line 1217: action.grace_period.expiry: xs:long Line 1218: action.name: xs:string > Why using name and not alias, as it is described when creating a new disk because the parameter type is action and the action does not have the "alias". I see 2 ways how to do it: 1: change the type from "action" to "disk" - but this would break compatibility (e.g. soonest time is 4.1) 2: add the "alias" to "action" - but the "action" is too generic to be enriched ad-hoc like this I'd say. @Juan: any other options? Because I agree that "alias" would be better just not sure I know how to do it properly. Line 1219: description: copy a disk to a different storage domain Line 1220: urlparams: {} Line 1221: headers: Line 1222: Content-Type: {value: application/xml|json, required: true} -- To view, visit https://gerrit.ovirt.org/38367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8931d2464d6ad17a80d9b394f16d01a2c47d7575 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
