Moti Asayag has uploaded a new change for review. Change subject: engine: Avoid spying HostMonitoring if not need ......................................................................
engine: Avoid spying HostMonitoring if not need Now, when all HostMonitoring Dependencies are mocked, it can be tested without mock/spy. Change-Id: I974aa32e3ae693983c7de5057af2d80c983a09e0 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/40951/1 diff --git a/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java b/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java index 4181a04..894fda1 100644 --- a/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java +++ b/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java @@ -11,7 +11,6 @@ import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Mock; -import org.mockito.Mockito; import org.mockito.runners.MockitoJUnitRunner; import org.ovirt.engine.core.common.businessentities.IVdsEventListener; import org.ovirt.engine.core.common.businessentities.VDS; @@ -79,12 +78,12 @@ initConditions(); when(vdsManager.getRefreshStatistics()).thenReturn(false); updater = - Mockito.spy(new HostMonitoring(vdsManager, + new HostMonitoring(vdsManager, vds, mock(MonitoringStrategy.class), resourceManager, dbFacade, - auditLogDirector)); + auditLogDirector); } private void initConditions() { @@ -108,7 +107,7 @@ VDSReturnValue value = new VDSReturnValue(); value.setSucceeded(false); value.setExceptionObject(new VDSNetworkException("unknown host")); - when(updater.getVdsEventListener()).thenReturn(vdsEventlistener); + when(resourceManager.getEventListener()).thenReturn(vdsEventlistener); when(resourceManager.runVdsCommand(any(VDSCommandType.class), any(VDSParametersBase.class))).thenReturn(value); -- To view, visit https://gerrit.ovirt.org/40951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I974aa32e3ae693983c7de5057af2d80c983a09e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
