Allon Mureinik has posted comments on this change.
Change subject: core: Added log for storage connection error (#854210)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
Line 93: return con;
Line 94: }
Line 95:
Line 96: private void logFailedStorageConnections(Map<String, String>
returnValue) {
Line 97: String failedDomainNames = "";
Use a StringBuilder
Line 98: String namesSeparator = ",";
Line 99: for (String storageId : returnValue.keySet()) {
Line 100: if (!"0".equals(returnValue.get(storageId))) {
Line 101: List<storage_domains> domains =
Line 95:
Line 96: private void logFailedStorageConnections(Map<String, String>
returnValue) {
Line 97: String failedDomainNames = "";
Line 98: String namesSeparator = ",";
Line 99: for (String storageId : returnValue.keySet()) {
Iterate over the entrySet instead of the keySet and using get()
Line 100: if (!"0".equals(returnValue.get(storageId))) {
Line 101: List<storage_domains> domains =
Line 102:
DbFacade.getInstance().getStorageDomainDao().getAllByConnectionId(new
Guid(storageId));
Line 103: if (!domains.isEmpty()) {
--
To view, visit http://gerrit.ovirt.org/8605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib412608941f1223eb52bbde85ef7ece52c64ec0f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
