Moti Asayag has posted comments on this change. Change subject: core: Extend Vm[Static] to contain provider id ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40717/4/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 1106: vm_dynamic.guest_mem_cached as guest_mem_cached, Line 1107: vm_dynamic.guest_mem_free as guest_mem_free, Line 1108: vm_static.small_icon_id as small_icon_id, Line 1109: vm_static.large_icon_id as large_icon_id, Line 1110: vm_static.provider_id as provider_id > IMO should be added to vms_with_tags as well haven't found justification for it. why do you think it is required ? Line 1111: FROM Line 1112: vm_static Line 1113: INNER JOIN vm_dynamic ON vm_static.vm_guid = vm_dynamic.vm_guid Line 1114: INNER JOIN vm_static AS vm_templates ON vm_static.vmt_guid = vm_templates.vm_guid https://gerrit.ovirt.org/#/c/40717/4/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 848: v_is_migrate_compressed BOOLEAN, Line 849: v_custom_emulated_machine VARCHAR(40), Line 850: v_custom_cpu_name VARCHAR(40), Line 851: v_small_icon_id UUID, Line 852: v_large_icon_id UUID, > No option to define the provider_id on a new entity when inserted ??? yes, we'll support adding provider to vm at creation time when we'll provision vms by Foreman. Up to that point we'll only support updating vms. Line 853: v_provider_id UUID) Line 854: Line 855: RETURNS VOID Line 856: -- To view, visit https://gerrit.ovirt.org/40717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c09188dcde40cbb5904dc15274d597ceb9b8594 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
