Moti Asayag has posted comments on this change.
Change subject: Engine: Rhev-H upgrade list show downgraded versions (#842767)
......................................................................
Patch Set 8: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetoVirtISOsTest.java
Line 32: private static final String OVIRT_ISOS_REPOSITORY_PATH =
"src/test/resources/ovirt-isos";
Line 33: private static final String OVIRT_ISOS_DATA_DIR = ".";
Line 34: private static final String AVAILABLE_OVIRT_ISO_VERSION = "RHEV
Hypervisor - 6.2 - 20111010.0.el6";
Line 35: private static final String UNAVAILABLE_OVIRT_ISO_VERSION = "RHEV
Hypervisor - 8.2 - 20111010.0.el6";
Line 36: private static final Version EXISTING_CLUSTER_VERSION = new
Version("3.1");
since this is a test, totally optional, but - you can replace it with
Version.v3_1
Line 37:
Line 38: @Rule
Line 39: public static MockConfigRule mcr = new MockConfigRule(
Line 40: mockConfig(ConfigValues.oVirtISOsRepositoryPath,
OVIRT_ISOS_REPOSITORY_PATH),
--
To view, visit http://gerrit.ovirt.org/7430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ae5263d565787ea7460f1d5f59beb77acff8b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
