Roy Golan has posted comments on this change. Change subject: core[Enum]: Adding external status enum ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40992/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalStatus.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalStatus.java: Line 7: Ok(0), Unassiged might play a good role if nothing is set. Ok may be leading as the default I guess. just a thought, I haven't read feature page Line 13: HashMap Use EnumMap instead of hash map. -- To view, visit https://gerrit.ovirt.org/40992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46af5206938025ad3c487cc1998b32301783cbf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
