Hello Eli Mesika, Omer Frenkel, Arik Hadas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/41038
to review the following change.
Change subject: core: Make DwhHeartBeat a BackendService and a CDI bean
......................................................................
core: Make DwhHeartBeat a BackendService and a CDI bean
Change-Id: I53589a48f302d6b3711afa144b666a1e1694406e
Signed-off-by: Roy Golan <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java
2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/41038/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
index dc8f4bd..5d5a488 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
@@ -103,9 +103,7 @@
SessionDataContainer.getInstance().cleanupEngineSessionsOnStartup();
loadService(HostDeviceManager.class);
-
- new DwhHeartBeat().init();
-
+ loadService(DwhHeartBeat.class);
} catch (Exception ex) {
log.error("Failed to initialize backend", ex);
throw ex;
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java
index 78c1e95..39468cf 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java
@@ -3,6 +3,7 @@
import java.util.Date;
import java.util.concurrent.TimeUnit;
+import org.ovirt.engine.core.common.BackendService;
import org.ovirt.engine.core.common.businessentities.DwhHistoryTimekeeping;
import
org.ovirt.engine.core.common.businessentities.DwhHistoryTimekeepingVariable;
import org.ovirt.engine.core.common.config.Config;
@@ -13,10 +14,14 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import javax.annotation.PostConstruct;
+import javax.inject.Singleton;
+
/**
* Job notifies DWH, that engine is up and running
*/
-public class DwhHeartBeat {
+@Singleton
+public class DwhHeartBeat implements BackendService {
/**
* Name of method to execute periodically
*/
@@ -49,7 +54,8 @@
/**
* Starts up DWH Heart Beat as a periodic job
*/
- public void init() {
+ @PostConstruct
+ private void init() {
log.info("Initializing DWH Heart Beat");
heartBeatVar = new DwhHistoryTimekeeping();
heartBeatVar.setVariable(DwhHistoryTimekeepingVariable.HEART_BEAT);
--
To view, visit https://gerrit.ovirt.org/41038
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I53589a48f302d6b3711afa144b666a1e1694406e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
