Juan Hernandez has posted comments on this change. Change subject: core, restapi: Support adding permission using role name ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40694/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java: Line 58: perm > You're filling fields in 'perm' which were not filled before. Should this b The "roleName" field that is filled here isn't used later, at least not now, the only field that is used is "roleId" and it is filled in below. So, there isn't a strict need to fill "roleName", but filling it makes things more consistent: after execution of this block of code both "roleName" and "roleId" will be filled and the values will be consistent. -- To view, visit https://gerrit.ovirt.org/40694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74f22e9bebbc102a45b76e9c62cc44961edadfbc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
