Omer Frenkel has posted comments on this change.
Change subject: core: WipeAfterDelete defaults to true in GUI, but false in
REST API (#845466)
......................................................................
Patch Set 5: (1 inline comment)
minor comment inside,
please also verify all related flows works well after this change
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/WipeAfterDeleteUtils.java
Line 8:
Line 9: private static final boolean WIPE_AFTER_DELETE_FILE_DOMAIN = false;
Line 10:
Line 11: public static boolean getDefaultWipeAfterDeleteFlag(final
StorageType storageType) {
Line 12: if(storageType.isBlockDomain()) {
please use formatter on the patch
Line 13: return
Config.<Boolean>GetValue(ConfigValues.SANWipeAfterDelete);
Line 14: } else {
Line 15: return WIPE_AFTER_DELETE_FILE_DOMAIN;
Line 16: }
--
To view, visit http://gerrit.ovirt.org/8628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cb77b017282733d72ff66af499b576674674e01
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
