Arik Hadas has posted comments on this change. Change subject: engine: Removal of VM pool with VMs ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40557/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java: Line 76: if (!vm.isDown()) { Line 77: CommandCoordinatorUtil.executeAsyncCommand( Line 78: VdcActionType.StopVm, Line 79: withRootCommandInfo(new StopVmParameters(vm.getId(), StopVmTypeEnum.NORMAL), getActionType()), Line 80: cloneContextAndDetachFromParent()); there is no async part for stop VM right? so why do you need to use the command-coordinator here? Line 81: } Line 82: } Line 83: } Line 84: -- To view, visit https://gerrit.ovirt.org/40557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b0f37903447b49edf74bea5a51108818701698 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shmuel Leib Melamud <[email protected]> Gerrit-Reviewer: Shmuel Melamud <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
