Martin Peřina has posted comments on this change.

Change subject: core:force bool fence agents options value
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/41103/1/packaging/dbscripts/upgrade/03_06_1400_fix_bool_fence_agents_options.sql
File packaging/dbscripts/upgrade/03_06_1400_fix_bool_fence_agents_options.sql:

Line 10: -- force all 'secure' in options to be 'secure=1'
Line 11: update fence_agents set options =  replace(options, 'secure=1', 
'TEMP_SECURE_EXPR') where not encrypt_options;
Line 12: update fence_agents set options =  replace(options, 'secure=true', 
'TEMP_SECURE_EXPR') where not encrypt_options;
Line 13: update fence_agents set options =  replace(options, 'secure', 
'secure=1') where not encrypt_options;
Line 14: update fence_agents set options =  replace(options, 
'TEMP_SECURE_EXPR', 'secure=1') where not encrypt_options;
> so lanplus and secure are the only ones affected?
That's are the options we are using even without user can notice (for example 
using by default even without specifying in options).
There may be other custom options specified by user that have to be changed, 
but as we talked with Eli we prefer not to touch them and let user do necessary 
changes.


-- 
To view, visit https://gerrit.ovirt.org/41103
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45f7a245dc01186f85619efd062c6f326c40d095
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to