Alona Kaplan has posted comments on this change. Change subject: webadmin: Support 'Upgrade' in action items ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/41023/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java: Line 1106: model.setTitle(constants.upgradeHostsTitle()); Line 1107: model.setHelpTag(HelpTag.upgrade_host); Line 1108: model.setHashName(HelpTag.upgrade_host.name); Line 1109: Line 1110: if (host.getVmCount() > 0) { This code is duplication of the code in HostListModel. Please create a new UpgradeHostModel which extends ConfirmationModel and contains the duplicated code. Line 1111: model.setMessage(constants.areYouSureYouWantToUpgradeTheFollowingHostWithRunningVmsMsg()); Line 1112: } else { Line 1113: model.setMessage(constants.areYouSureYouWantToUpgradeTheFollowingHostMsg()); Line 1114: } -- To view, visit https://gerrit.ovirt.org/41023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e9053aec1cb4aa69e5b35c882b8ac71224f6a9b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
