Michal Skrivanek has posted comments on this change. Change subject: agent: Added APT package list support (BZ#838632) ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) we may need a separate branch for 3.2 .................................................... Commit Message Line 9: The newly added functionality allows the guest agent to report installed Line 10: packages and their version even on systems with APT package managers Line 11: (e.g Debian) Line 12: Line 13: Change-Id: I42d9d599b1effdd1b8c205ac9523e9b31922cd73 please add Bug-Url: see the template at wiki .................................................... File ovirt-guest-agent/GuestAgentLinux2.py Line 64: apt_pkg.init() Line 65: self.apt_pkg = apt_pkg Line 66: self.list_pkgs = self.apt_list_packages Line 67: except: Line 68: raise NotImplementedError does this stop the agent? We may want to actually continue even when all the above fails. Just return empty app list and log an err Line 69: Line 70: class NicMgr(object): Line 71: Line 72: def ethtool_list_nics(self): -- To view, visit http://gerrit.ovirt.org/8642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42d9d599b1effdd1b8c205ac9523e9b31922cd73 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Gal Hammer <gham...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
