Omer Frenkel has posted comments on this change. Change subject: core: add configuraion for hot plug memory ......................................................................
Patch Set 1: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/41138/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 200: select fn_db_add_config_value_for_versions_up_to('HotPlugCpuSupported', '{"x86_64":"false","ppc64":"false"}', '3.3'); Line 201: select fn_db_add_config_value_for_versions_up_to('HotPlugCpuSupported', '{"x86_64":"true","ppc64":"false"}', '3.6'); Line 202: select fn_db_add_config_value_for_versions_up_to('HotUnplugCpuSupported', '{"x86_64":"false","ppc64":"false"}', '3.6'); Line 203: select fn_db_add_config_value_for_versions_up_to('HotPlugMemorySupported', '{"x86_64":"false","ppc64":"false"}', '3.5'); Line 204: select fn_db_add_config_value_for_versions_up_to('HotUnplugMemorySupported', '{"x86_64":"false","ppc64":"false"}', '3.6'); > Is it intended that default value for both is the same? currently hotplug mem support starts from 3.6 this is why i set it to false up tp 3.5, and in the code its true (means true in 3.6 and on) unplug should be supported but not yet so for now i set it as false also in 3.6 do you see any issue? regarding cpu above, it was supported starting 3.4 this is why it is set with false up-to 3.3 and then set to true for versions up to 3.6 (i assume its because the support was in question up to the last minute and we changed it after 3.4 was out but not sure) Line 205: Line 206: -- migration support per architecture Line 207: select fn_db_add_config_value('IsMigrationSupported','{"undefined": "true", "x86_64": "true", "ppc64" : "true" }','general'); Line 208: -- snapshot support per architecture -- To view, visit https://gerrit.ovirt.org/41138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff5ca4b827ff8bbcdc1417677e98f908ac60fbc9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
