Martin Peřina has posted comments on this change. Change subject: core: Add support for WildFly ......................................................................
Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/40152/12/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 57: %global ovirt_provides_jboss 1 Line 58: %global jboss ovirt-engine-wildfly Line 59: %global ovirt_wildfly_overlay 1 Line 60: %global ovirt_wildfly_fixup 1 Line 61: %endif > since above fedora >= 20 branch has become identical to the other branch I Done Line 62: %if %{fedora} >= 21 Line 63: %global docker docker Line 64: %else Line 65: %global docker docker-io Line 84: %global ovirt_require_maven 0 Line 85: %global ovirt_provides_jboss 1 Line 86: %global jboss ovirt-engine-wildfly Line 87: %global ovirt_wildfly_overlay 1 Line 88: %global ovirt_wildfly_fixup 1 > Unless there's a real reason for keeping these, I'd move these 3 lines in t Alon wanted to leave those per os version as we don't know when/if we could reuse existing package for each os version. Line 89: %global docker docker-io Line 90: Line 91: # emulate fedora java for simplicity Line 92: %undefine add_maven_depmap -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Max Kovgan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
