Allon Mureinik has posted comments on this change.
Change subject: core: fix err msg-add disk to locked VM (#865551)
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 457: if (checkIsValid && !isValid) {
Line 458: returnValue = false;
Line 459: ListUtils.nullSafeAdd(messages,
VdcBllMessages.ACTION_TYPE_FAILED_IMAGE_REPOSITORY_NOT_FOUND.toString());
Line 460: }
Line 461:
No, the entire method should be moved to /dev/null are replaced with a bunch of
smaller functions instead of all the booleans.
Once we do that, it will return early ouf of the box.
Line 462: List<DiskImage> images = getImages(vm, diskImageList);
Line 463: if (returnValue && checkImagesLocked) {
Line 464: List<String> lockedDisksAliases = new ArrayList<String>();
Line 465: for (DiskImage diskImage : images) {
--
To view, visit http://gerrit.ovirt.org/8666
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7a82d91b0ee51ebd1a612dbf210e0ea4533e746
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
