Vinzenz Feenstra has posted comments on this change. Change subject: Allow to avoid lock screen on spice disconnect ......................................................................
Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/34079/22/packaging/dbscripts/upgrade/03_06_1450_add_vm_static_console_disconnect_action.sql File packaging/dbscripts/upgrade/03_06_1450_add_vm_static_console_disconnect_action.sql: Line 1: select fn_db_add_column('vm_static', 'console_disconnect_action', 'VARCHAR(64)'); > Eli you can see the values, in this patch: Well I have added NULL handling and the column is not marked as 'NOT NULL' therefore that shouldn't be a problem. I can by default make them all 'LOCK_SCREEN' however using NULL is less prone to programming errors due to potential typos. 64 Chars is plenty, and not supposed to be user defined content. It all comes from the enums. -- To view, visit https://gerrit.ovirt.org/34079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2ef5ffaceed619f6630b56a7156f25e9111fd9e Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
