Ayal Baron has posted comments on this change.
Change subject: core: DeactivateStorageDomainCommand cleanup
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
Line 107: .isEmpty()) {
Line 108:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_DETECTED_ACTIVE_VMS);
Line 109: return false;
Line 110: }
Line 111: }
this may be a gerrit presentation issue but looks like indentation here is
wrong.
Line 112: if (getStoragePool().getspm_vds_id() != null) {
Line 113: // In case there are running tasks in the pool, it is
impossible to deactivate the master storage domain
Line 114: if (getStorageDomain().getstorage_domain_type() ==
StorageDomainType.Master &&
Line 115:
getAsyncTaskDao().getAsyncTaskIdsByStoragePoolId(getStorageDomain().getstorage_pool_id().getValue()).size()
> 0) {
--
To view, visit http://gerrit.ovirt.org/8513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52d5be0a53876ad8494e1d6068aaff057512d6d8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
