Omer Frenkel has posted comments on this change. Change subject: backend: Implementation support for GuestOsInfo and Timezone reporting ......................................................................
Patch Set 19: (2 comments) https://gerrit.ovirt.org/#/c/29322/19/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 442: } catch(IllegalArgumentException e) { Line 443: log.warn("Invalid or unknown guest architecture type '{}' received from guest agent", arch); Line 444: } Line 445: } else { Line 446: log.warn("Guest OS architecture not reported by guest agent but expected."); do we really want to warn if this is missing? (remember it happens every 15secs) Line 447: } Line 448: vm.setGuestOsCodename(AssignStringValue(guestOsInfoStruct, VdsProperties.GUEST_OS_INFO_CODENAME)); Line 449: vm.setGuestOsDistribution(AssignStringValue(guestOsInfoStruct, VdsProperties.GUEST_OS_INFO_DISTRIBUTION)); Line 450: vm.setGuestOsKernelVersion(AssignStringValue(guestOsInfoStruct, VdsProperties.GUEST_OS_INFO_KERNEL)); Line 450: vm.setGuestOsKernelVersion(AssignStringValue(guestOsInfoStruct, VdsProperties.GUEST_OS_INFO_KERNEL)); Line 451: if(guestOsInfoStruct.containsKey(VdsProperties.GUEST_OS_INFO_TYPE)) { Line 452: String osType = AssignStringValue(guestOsInfoStruct, VdsProperties.GUEST_OS_INFO_TYPE); Line 453: try { Line 454: vm.setGuestOsType(osType); this will never throw exception because there is try..catch inside, i think you can remove the code inside the setter and just handle a bad value here Line 455: } catch(IllegalArgumentException e) { Line 456: log.warn("Invalid or unknown guest os type '{}' received from guest agent", osType); Line 457: } Line 458: } else { -- To view, visit https://gerrit.ovirt.org/29322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1e54d39706601c0faf9d76785f1257ee20755b Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
