Omer Frenkel has posted comments on this change. Change subject: core: always send numa node for vm ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40481/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 1265: List<VmNumaNode> vmNumaNodes = DbFacade.getInstance().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(vm.getId()); Line 1266: List<VdsNumaNode> totalVdsNumaNodes = DbFacade.getInstance().getVdsNumaNodeDAO() Line 1267: .getAllVdsNumaNodeByVdsId(vdsId); Line 1268: if (totalVdsNumaNodes.isEmpty()) { Line 1269: log.warn("No NUMA nodes found for host {} for vm {} {}", vdsId, vm.getName(), vm.getId()); > hold on, why do we warn/care here if the host reports any numa or not? (I s this reflects the numa settings of the host. if host doesn't report this (not sure how it can happen, maybe problematic kernel?) then we wouldn't know the cpuIds to send Line 1270: return; Line 1271: } Line 1272: Line 1273: // if user didn't set specific NUMA conf -- To view, visit https://gerrit.ovirt.org/40481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c7b0938bb0ab45883d637b594de61cd8695963a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
