Alon Bar-Lev has posted comments on this change. Change subject: tools: extensions-tool: initial implementation aaa ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/41605/1/backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties File backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties: Line 57: authn-authenticate_credentials.help.header = Authn action of aaa interface test module Line 58: authn-authenticate_credentials.help.usage = @PROGRAM_NAME@ aaa login [options] Line 59: authn-authenticate_credentials.help.footer = \ Line 60: Example:\n\ Line 61: \ @PROGRAM_NAME@ aaa authn-authenticate_credentials --extension-name=my_ldap-authn --user-name=user we probably need also authz-fetch_principal_record to be able to test only authz detached from the login sequence. Line 62: Line 63: Line 64: login-user.arg.profile-name.name = profile-name Line 65: login-user.arg.profile-name.mandatory = true Line 91: login-user.help.footer = \ Line 92: Example:\n\ Line 93: \ @PROGRAM_NAME@ aaa login-user --profile-name=my_ldap --user-name=user Line 94: Line 95: search.arg.authz-name.name = authz-name you can have extension name here as well, no? Line 96: search.arg.authz-name.mandatory = true Line 97: search.arg.authz-name.type = has_argument Line 98: search.arg.authz-name.help = Name of authz extension to perform search with Line 99: Line 98: search.arg.authz-name.help = Name of authz extension to perform search with Line 99: Line 100: search.arg.namespace.name = namespace Line 101: search.arg.namespace.type = has_argument Line 102: search.arg.namespace.help = Namespace to search within we should also be able to perform info on authn/authz to receive important fields, such as flags and namespace in this case. Line 103: Line 104: search.arg.entity.name = entity Line 105: search.arg.entity.mandatory = true Line 106: search.arg.entity.type = has_argument Line 136: search.arg.resolve-groups-recursive.name = resolve-groups-recursive Line 137: search.arg.resolve-groups-recursive.help = Resolve groups recursive Line 138: search.arg.resolve-groups-recursive.valuetype = java.lang.Integer Line 139: search.arg.resolve-groups-recursive.value = 2 Line 140: search.arg.resolve-groups-recursive.default = 0 better to use single flags argument and many values. Line 141: Line 142: search.arg.help.name = help Line 143: search.arg.help.help = Show help for search action. Line 144: search.arg.help.valuetype = java.lang.Boolean -- To view, visit https://gerrit.ovirt.org/41605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1811c5845bf02c30f1acd2938074070fb661af38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
