Martin Polednik has posted comments on this change. Change subject: hostdev: add support for enabling IOMMU on the host ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41507/3/src/plugins/ovirt-host-deploy/hostdev/iommu.py File src/plugins/ovirt-host-deploy/hostdev/iommu.py: Line 102: self._regenerate_grub() Line 103: Line 104: def _update_grub_conf(self): Line 105: content = '' Line 106: with open(odeploycons.FileLocations.GRUB_CONFIG_FILE, 'r') as f: > why using /etc/default/grub ? this is something the user can change at will then the new entry wouldn't (afaik) be the default one and therefore the feature wouldn't be enabled Line 107: for line in f: Line 108: if 'GRUB_CMDLINE_LINUX' in line: Line 109: content += ( Line 110: line.rstrip('"\n') + '%s=on"\n' % self._CMDLINE_IOMMU[ -- To view, visit https://gerrit.ovirt.org/41507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceb4cf0a548cd9ffacb47afb825217042832c36f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
