Arik Hadas has posted comments on this change. Change subject: core: add timestamp for vm-dynamic updates ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41520/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java: Line 53: this.resourceManager = resourceManager; Line 54: } Line 55: Line 56: public void fetch() { Line 57: fetchTime = Calendar.getInstance().getTime(); since we are going to compute this time-stamp a lot, perhaps we should use the more efficient way of System.currentTimeMillis(). See: http://stackoverflow.com/questions/368094/system-currenttimemillis-vs-new-date-vs-calendar-getinstance-gettime Line 58: VDSReturnValue getList = Line 59: getResourceManager().runVdsCommand( Line 60: VDSCommandType.List, Line 61: new VdsIdAndVdsVDSCommandParametersBase(vdsManager.getCopyVds())); -- To view, visit https://gerrit.ovirt.org/41520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If858993450cf957babdcf337e9b7867a282657bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
