Arik Hadas has posted comments on this change. Change subject: core: add template from snapshot ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/41258/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java: Line 34: @NonTransactiveCommandAttribute(forceCompensation = true) Line 35: public class AddVmTemplateFromSnapshotCommand<T extends AddVmTemplateFromSnapshotParameters> extends AddVmTemplateCommand<T> { Line 36: Line 37: private Snapshot cachedSnapshot; Line 38: private VM cachedVmFromConfiguration; > why is this needed in addition to the existing cached vm in the command? i Done Line 39: private List<DiskImage> cachedDisksFromDb; Line 40: Line 41: public AddVmTemplateFromSnapshotCommand(Guid commandId) { Line 42: super(commandId); -- To view, visit https://gerrit.ovirt.org/41258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4262e738110f868c9987f5bc4b87325acabb7ad3 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
